Skip to content

Check whether the "type" key in error responses is present #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icing merged 1 commit into from
Mar 13, 2026
Merged

Check whether the "type" key in error responses is present #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions src/md_acme.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,22 +182,24 @@ static apr_status_t inspect_problem(md_acme_req_t *req, const md_http_response_t

req->resp_json = problem;
ptype = md_json_gets(problem, MD_KEY_TYPE, NULL);
pdetail = md_json_gets(problem, MD_KEY_DETAIL, NULL);
req->rv = problem_status_get(ptype);
md_result_problem_set(req->result, req->rv, ptype, pdetail,
md_json_getj(problem, MD_KEY_SUBPROBLEMS, NULL));



if (APR_STATUS_IS_EAGAIN(req->rv)) {
md_log_perror(MD_LOG_MARK, MD_LOG_DEBUG, req->rv, req->p,
"acme reports %s: %s", ptype, pdetail);
}
else {
md_log_perror(MD_LOG_MARK, MD_LOG_WARNING, req->rv, req->p,
"acme problem %s: %s", ptype, pdetail);

if (ptype) {
req->rv = problem_status_get(ptype);
pdetail = md_json_gets(problem, MD_KEY_DETAIL, NULL);

md_result_problem_set(req->result, req->rv, ptype, pdetail,
md_json_getj(problem, MD_KEY_SUBPROBLEMS, NULL));

if (APR_STATUS_IS_EAGAIN(req->rv)) {
md_log_perror(MD_LOG_MARK, MD_LOG_DEBUG, req->rv, req->p,
"acme reports %s: %s", ptype, pdetail);
}
else {
md_log_perror(MD_LOG_MARK, MD_LOG_WARNING, req->rv, req->p,
"acme problem %s: %s", ptype, pdetail);
}
return req->rv;
}
return req->rv;
}
}

Expand Down
Loading