Improve handling of failed ACME account verifications#415
Open
mkauf wants to merge 1 commit intoicing:masterfrom
Open
Improve handling of failed ACME account verifications#415mkauf wants to merge 1 commit intoicing:masterfrom
mkauf wants to merge 1 commit intoicing:masterfrom
Conversation
When saving the updated ACME account to the disk, don't set directory permissions if they are already correct. Setting directory permissions may fail if the Apache Server is not running as root anymore. Avoid an endless loop if an ACME account cannot be verified. Fixes icing#410
mkauf
force-pushed
the
improve_account_verification
branch
from
f7be1dc to
1e7716d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving the updated ACME account to the disk, don't set directory permissions if they are already correct. Setting directory permissions may fail if the Apache Server is not running as root anymore.
Avoid an endless loop if an ACME account cannot be verified.
Fixes #410