Fix black screen bug by make CameraManager a singleton#61
Open
jiaminglu wants to merge 1 commit intoideacreation:masterfrom
Open
Fix black screen bug by make CameraManager a singleton#61jiaminglu wants to merge 1 commit intoideacreation:masterfrom
jiaminglu wants to merge 1 commit intoideacreation:masterfrom
Conversation
Fix "Method called after release()" caused by calling stopCameraPreview twice
jiaminglu
changed the title
|
@ideacreation If this PR is merged, it would be useful. @jiaminglu Thank you for the PR, wondering how to use this into my project in case the PR is not yet merged. Should I copy the |
|
@vysakh0 I just added |
|
@Scimonster Thank you! Initially I used |
|
Can we marge it ? |
|
Are there any blockers, which prevent @andreaskeller from merging this PR and release this bug? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed a error log "Method called after release()" caused by calling stopCameraPreview twice