use only url path for getLocalBack() method#21
Open
kertkulp wants to merge 1 commit intoied3vil:masterfrom
Open
use only url path for getLocalBack() method#21kertkulp wants to merge 1 commit intoied3vil:masterfrom
kertkulp wants to merge 1 commit intoied3vil:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use only the path for
getLocalBack()method otherwise if the domain contains language slug theifcheck in method fails and redirect ULR doesn't get updated.EXAMPLE
if the
$backUrlis https://messenger.com/en/ and the$currentisenthen the first instance ofenis inmessENgerand not in the path. That causes theifto fail and therefor redirect url doesn't get changed and the user is just redirected back to the initial URL.