make loss.backward() work#84
Open
allenhung1025 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for creating the PR. I am not entirely sure if this issue is coming up due to the box-embeddings library—we have been able to backprop successfully while using gumbel intersection. Would you be able to create a small test case that isolates this issue this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use gumbel_intersection in my training code. However, when calling the loss.backward(), there would be an error message. Imgur which shows that there should not be an in-place operation with tunable parameter. After I made some changes in the intersection function, the code worked out.