Added cmake for building the project and CPM for auto package management#5
Added cmake for building the project and CPM for auto package management#5wtrsltnk wants to merge 2 commits into
Conversation
| UserData *userData = static_cast<UserData *>(pUserData); | ||
|
|
||
| if (command == 144) { | ||
| if ((command & 0xf0) == 144) { |
There was a problem hiding this comment.
What is the purpose of adding 0xf0 here, and the 0x0f two lines below? I'm not very familiar with MIDI...
There was a problem hiding this comment.
Sorry for the late reply!
The command byte has two functions. The first is the command, the second is the midi channel it is supposed to send the comand to. The '& 0xf0' will remove channel part from the byte and make sure only the command part is checked. I had to add this to be able to support sending commands over multiple midi channels. When you send a midi command over channel 5 for example, the command value will not be 144.
|
Thanks so much for contributing CMake support! I'm sorry it's taken me so long to reply to this PR. I'll get this merged in soon; if you can reply to the question I put above that'd be helpful. (This is my first time merging in a non-trivial PR, so not sure what the most convenient way is to review code with other contributors). |
2 participants
Nice project! I got it working with cmake and CPM on windows and was wondering if you could use this. The CPM is auto downloading all the dependancies VST and concurrentqueue. I had to remove the SDL2/ in the SDL includes. Thats an result of using CPM and I am not sure how to fix that yet..