Add, test/{end,start}.js; Update, lib/index.js#5
Open
amagura wants to merge 11 commits intoifit:masterfrom
amagura:master
Open
Add, test/{end,start}.js; Update, lib/index.js#5amagura wants to merge 11 commits intoifit:masterfrom amagura:master
amagura wants to merge 11 commits intoifit:masterfrom
amagura:master
Conversation
test/{end,start}.js:
tests showing how to use the new queue targets: `first' and `last'.
lib/index.js:
1. added support for new queue targets: `first' and `last'.
First can be used to create an infinite loop, which might be desirable in the case of watchers: programs that watch other programs and alert peeps when those programs die.
…x.js end-begin.js: Combined both the `start.js` and the `end.js` tests into a single test file. index.js: 1. changed `last` -> `ending` 2. changed `first` -> `beginning`
* Added another test for beginning and ending * Added usage-examples of beginning and ending to the README
fixed a typo
Contributor
There was a problem hiding this comment.
make the example simpler and more straightforward. We don't want people getting bogged down in grokking a ternary
Author
|
@regality ready for you to review again, I believe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/{end,start}.js:
tests showing how to use the new queue targets:
firstandlast.lib/index.js:
firstandlast.