fix(auth): prevent USER_ADMIN from downgrading SUPER_ADMIN users#564
Open
kjken23 wants to merge 1 commit into
Open
fix(auth): prevent USER_ADMIN from downgrading SUPER_ADMIN users#564kjken23 wants to merge 1 commit into
kjken23 wants to merge 1 commit into
Conversation
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPER_ADMINcan change role state involvingSUPER_ADMIN.USER_ADMINfrom downgrading or replacing an existingSUPER_ADMINaccount withUSERor another platform role.This is needed because the previous backend check only blocked non-
SUPER_ADMINactors from assigningSUPER_ADMIN; it did not protect target users who already hadSUPER_ADMIN.Closes #562
Validation
Commands run:
Result:
OpenAPI impact:
Frontend impact:
Smoke test:
Risk
USER_ADMINcan still manage ordinary users, but attempts to mutate an existingSUPER_ADMINnow return a forbidden error unless the actor is alsoSUPER_ADMIN.Notes