fix: wrap Observer in IIFE to prevent redeclaration on View Transitions#57
Merged
Conversation
The `const Observer` in BasicScripts.astro was declared at the top level of an is:inline script. When Astro's client router swaps pages, the script re-executes and tries to redeclare Observer, causing a SyntaxError. Wrapping in an IIFE creates a function scope that avoids the collision. Also update CHANGELOG with CI workflow fix and this JS error fix. Signed-off-by: dongjiang <dongjiang1989@126.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
FenjuFu
approved these changes
Jul 15, 2026
FenjuFu
left a comment
FenjuFu
left a comment
Contributor
There was a problem hiding this comment.
Verified the whitespace-ignored diff is a pure IIFE wrap with no logic change, and confirmed the ADMIN_PAT changelog entry matches the current workflows. All checks green. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changes
Fixed
const ObserverinBasicScripts.astrotop-levelis:inlinescript causedSyntaxError: Identifier 'Observer' has already been declaredwhen Astro client router swapped pages — wrapped in IIFE(() => { ... })()to create function scopeChangelog
[Unreleased]Test plan
npm run checkpasses (astro check, eslint, prettier) — 0 errors, 0 warnings, 0 hintsnpm run buildcompletes successfully