docs: tracking-split editorial polish - REGISTRY decision folds + history scrub (split 3/3) - #708
Conversation
…lassifications + history scrub (3/3) Applies the decisions rule shipped in the split: behavioral decisions live as REGISTRY Notes, the Decision record keeps engineering calls + one-line pointers. - NEW REGISTRY StackedDiD Note (base-estimator notes block): intercept SEs excluded from R parity - for the base clubSandwich parity fixture (not the CBWSDID cbwsdid fixture), interaction SEs match ~2e-13 while the regression intercept SE differs by a measured ~0.3% (nuisance-parameter reference-cell gap, not machine-precision lockable); surfacing se_cr1_intercept/se_cr2_intercept would add an unasserted, R-divergent public field. The estimatr-intercept and zero-weight-PSU decisions already had REGISTRY Notes; their Decision-record rows shrink to pointers at those Notes. - Reclassify two closed decisions out of Parked into the Decision record (3-col shape): StackedDiD survey re-resolution dedup (assessed, not warranted; #226) and the HAD Pierce-Schott replication harness (waived 2026-05-20). Parked 34, Decision record 10. - History scrub: DONE/SHIPPED/LANDED narration compressed to residual-only statements (conformal one-sided/covariates sentence dropped; CGBS row leads with the remaining extensions; HonestDiD landed-support sentence dropped; Conley row states SA+Wooldridge-OLS support as scope, not history; LPDiD non-absorbing row retitled to the actual residual gap (Stata-only SE/RA reference); CiC Melly-Santangelo and CS unbalanced-panel rows lead with what remains). Reviewer-crediting Location + reason text preserved on every row; uppercase history flags now appear only inside the Decision record. Markdown-only; no library behavior change. Verified: row-integrity counts (9 actionable; 15/18/34/1/10), no orphaned cross-references, strict -W docs build green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H8PDhdrdQH2DM8yAeEnib7
Overall assessment✅ Looks good — no unmitigated P0 or P1 findings. Executive summary
Methodology
Code QualityNo findings; no source code changed. PerformanceNo findings. MaintainabilityNo findings beyond the documentation pointers below. Tech DebtNo findings. Actionable, deferred, parked, version-gated, and decision-record counts are internally consistent. SecurityNo findings or apparent secrets. Documentation/Tests
No test changes are required for this editorial-only PR. |
… bullet + waived-status wording - REGISTRY HAD mass-point intercept-SE bullet relabeled with the reviewer-recognized form (**Note (deviation from R — classical intercept SE):**) so the DEFERRED.md decision-record pointer resolves to a labeled Note. - The two HAD Phase-4 checklist tails now say "Recorded as waived in the DEFERRED.md decision record" instead of claiming an active Low-priority follow-up (the row moved to the Decision record in this PR). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H8PDhdrdQH2DM8yAeEnib7
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall assessment✅ Looks good — no unmitigated P0 or P1 findings. Executive summary
Methodology
Code QualityNo findings; source code was not changed. PerformanceNo findings. MaintainabilityNo findings. Engineering waivers are appropriately consolidated in the decision record. Tech DebtNo findings. Tracking rows and category counts remain internally consistent. SecurityNo findings or apparent secrets. Documentation/TestsNo findings. The prior stale HAD backlog wording is corrected at |
Summary
clubSandwichparity fixture (not the CBWSDIDcbwsdidfixture), event-study interaction SEs match ~2e-13 while the regression intercept SE differs by a measured ~0.3% (nuisance-parameter reference-cell gap); surfacingse_cr1_intercept/se_cr2_interceptwould add an unasserted, R-divergent public field. The estimatr-intercept and zero-weight-PSU decisions already had REGISTRY Notes, so their Decision-record rows shrink to pointers.Location+ reason text preserved on every row; uppercase history flags now appear only inside the Decision record, where provenance is the point.Methodology references (required if estimator / math changes)
Validation
make -C docs html SPHINXOPTS="-W"build green.Security / privacy
🤖 Generated with Claude Code
https://claude.ai/code/session_01H8PDhdrdQH2DM8yAeEnib7