sound: honor the member loop flag for puppetSound / score sounds#191
Open
chameleonxxl wants to merge 1 commit into
Open
sound: honor the member loop flag for puppetSound / score sounds#191chameleonxxl wants to merge 1 commit into
chameleonxxl wants to merge 1 commit into
Conversation
chameleonxxl
requested a deployment
to
fork-pr-tests
GitHub Actions
Waiting
chameleonxxl
requested a deployment
to
fork-pr-tests
GitHub Actions
Waiting
handle_play_file unconditionally reset loop_count to 1 right after puppet_sound had derived it from the sound member's loop flag (0 = loop forever, 1 = play once). That clobber made every score-channel and puppetSound sound play once — a looping intro track (e.g. mobilesdisco's music in sound channel 1, member loop enabled) never repeated. Thread the loop count through handle_play_file instead of hardcoding it: puppet_sound passes the derived value; direct `sound playFile` passes 1 (unchanged play-once). Once loop_count is 0, play_file stores the member for replay and start_sound enables native looping.
chameleonxxl
force-pushed
the
cham/ec-sound-loop
branch
from
b848d1c to
6e5bfd5
Compare
chameleonxxl
had a problem deploying
to
fork-pr-tests
GitHub Actions
Failure
chameleonxxl
temporarily deployed
to
fork-pr-tests
GitHub Actions
Inactive
Contributor
Snapshot Test Report (native)All 2 snapshots match the reference images. Generated by CI — 2026-06-08T21:21:54Z |
Contributor
Snapshot Test Report (browser)1 of 164 snapshots differ from reference. Red pixels indicate changes. Generated by CI — 2026-06-08T21:34:01Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_play_file unconditionally reset loop_count to 1 right after puppet_sound had derived it from the sound member's loop flag (0 = loop forever, 1 = play once). That clobber made every score-channel and puppetSound sound play once — a looping intro track (e.g. mobilesdisco's music in sound channel 1, member loop enabled) never repeated.
Thread the loop count through handle_play_file instead of hardcoding it: puppet_sound passes the derived value; direct
sound playFilepasses 1 (unchanged play-once). Once loop_count is 0, play_file stores the member for replay and start_sound enables native looping.