Skip to content

📖 Scribe: Document meshguard connect CLI command#62

Closed
igorls wants to merge 1 commit intomainfrom
scribe-add-connect-cli-3006533866175062450
Closed

📖 Scribe: Document meshguard connect CLI command#62
igorls wants to merge 1 commit intomainfrom
scribe-add-connect-cli-3006533866175062450

Conversation

@igorls
Copy link
Owner

@igorls igorls commented Mar 5, 2026

💡 What: Added missing documentation for meshguard connect command to docs/reference/cli.md.
🔍 Source: src/main.zig
📝 Fix: Documented the connect command, its flags (--generate, --join, --in), and the connection flow.


PR created automatically by Jules for task 3006533866175062450 started by @igorls

The `meshguard connect` command enables direct peer connection via token
exchange (bypassing seed nodes) and performs a coordinated UDP hole punch.
This command is implemented in `src/main.zig` but was missing from the
CLI reference documentation.

This commit adds the missing `meshguard connect` command documentation
to `docs/reference/cli.md` to truthfully reflect the codebase implementation.

Co-authored-by: igorls <4753812+igorls@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings March 5, 2026 11:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing CLI reference documentation for meshguard connect, aligning the docs with the command’s built-in help/usage in src/main.zig.

Changes:

  • Documented meshguard connect purpose and basic usage (--generate / --join).
  • Added flag reference for --generate, --join, and --in.
  • Described the token-exchange flow for coordinated punching.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@igorls
Copy link
Owner Author

igorls commented Mar 9, 2026

Closing: superseded by docs audit fixes and direct commits to main. See PR #67 (merged) for codec bounds check, and direct commit for timing-safe fix in noise.zig.

@igorls igorls closed this Mar 9, 2026
@google-labs-jules
Copy link
Contributor

Closing: superseded by docs audit fixes and direct commits to main. See PR #67 (merged) for codec bounds check, and direct commit for timing-safe fix in noise.zig.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants