Improve test coverage for edge cases#47
Merged
igormilovanovic merged 1 commit intomasterfrom Feb 20, 2026
Merged
Conversation
Add 25 new tests covering: - Empty files, comment-only files, blank lines - Mixed tabs/spaces, leading/trailing whitespace - IPv6 entries (::1, fe80::1, 2001:db8::1) - Malformed lines (invalid IP, IP-only, garbage) - Inline comment variations - File handling (nonexistent file, backup, no-header save, reload) - Operations (remove nonexistent, find multiple by IP, allow_duplicates) - Slice access, repr/str, __contains__ with wrong type - Host.from_line edge cases Closes #35 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def test_nonexistent_file_creates_empty_list(self): | ||
| """Test that a nonexistent file path results in empty hosts list.""" | ||
| temp_path = Path(tempfile.mktemp(suffix='.hosts')) |
Check failure
Code scanning / CodeQL
Insecure temporary file High test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/test_edge_cases.pycovering parsing, file handling, operations, andHost.from_lineedge casesCloses #35
Test plan
🤖 Generated with Claude Code