Make React Notification system compatible with react 17 or 18#184
Open
Oskku wants to merge 5 commits intoigorprado:masterfrom
Open
Make React Notification system compatible with react 17 or 18#184Oskku wants to merge 5 commits intoigorprado:masterfrom
Oskku wants to merge 5 commits intoigorprado:masterfrom
Conversation
Oskku
changed the title
|
@igorprado Could you merge this change? |
sbimochan
reviewed
Dec 28, 2023
| "react-tools": "^0.13.2", | ||
| "react-transform-catch-errors": "^1.0.0", | ||
| "react-transform-hmr": "^1.0.1", | ||
| "create-react-class":"^15.7.0", |
There was a problem hiding this comment.
where is this used? And please squash your commits.
There was a problem hiding this comment.
Sorry i left my old account should i push it from here again or ?
There was a problem hiding this comment.
sure. maybe create a new PR. the commits looks naive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works now with react 17 or 18