Fix command-service KafkaTemplate bean wiring by igorsatsyuk · Pull Request #154 · igorsatsyuk/distributed-audit-ledger

igorsatsyuk · 2026-05-24T15:56:46Z

Description

adds explicit KafkaTemplate<String, AuditEvent> configuration in KafkaProducerConfig
configures producer bootstrap and serializer settings explicitly for command-service
resolves startup failure where AuditCommandPublisher could not autowire typed KafkaTemplate

Testing

command-service startup verified after fix
auth/login and command publish path rechecked in local runtime flow used by demo screenshots

Copilot

Pull request overview

This PR adds an explicit, strongly-typed KafkaTemplate<String, AuditEvent> (and backing ProducerFactory) to command-service to resolve a startup autowiring failure in AuditCommandPublisher when Spring Boot’s default KafkaTemplate bean is not type-compatible.

Changes:

Introduces KafkaProducerConfig to register ProducerFactory<String, AuditEvent> and KafkaTemplate<String, AuditEvent> beans.
Sets producer bootstrap server and serializer configuration in the new producer factory.
Disables JSON type headers for produced events.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

…erviceIntegrationTest meta-annotation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

…verrides Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

… producer-specific overrides Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Fix command-service KafkaTemplate wiring

33ca016

Copilot AI review requested due to automatic review settings May 24, 2026 15:56

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 15:56 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Address review feedback for KafkaProducerConfig

4699214

igorsatsyuk requested a review from Copilot May 24, 2026 16:05

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 16:05 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread ...d-service/src/main/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfig.java Outdated

Comment thread ...d-service/src/main/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfig.java

[#154] Add SpringBootTest for KafkaProducerConfig bean wiring

cd391f5

igorsatsyuk requested a review from Copilot May 24, 2026 16:17

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 16:17 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread ...d-service/src/main/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfig.java

Comment thread ...d-service/src/main/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfig.java

igorsatsyuk requested a review from Copilot May 24, 2026 16:48

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 16:48 View session

igorsatsyuk review requested due to automatic review settings May 24, 2026 16:48

[#154] Align Kafka producer wiring with Spring config

bbb4640

igorsatsyuk requested a review from Copilot May 24, 2026 16:55

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 16:55 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

[#154] Remove deprecated JsonSerializer references

a60307e

igorsatsyuk requested a review from Copilot May 24, 2026 17:11

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 17:11 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

[#154] Address remaining review feedback

e6eb8ec

igorsatsyuk requested a review from Copilot May 24, 2026 17:25

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 17:26 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread ...est/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfigIntegrationTest.java Outdated

Comment thread ...d-service/src/main/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfig.java Outdated

[#154] Address review: use JsonSerializer.class literal and @CommandS…

ed5af59

…erviceIntegrationTest meta-annotation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

igorsatsyuk requested a review from Copilot May 24, 2026 17:36

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 17:36 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread ...d-service/src/main/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfig.java

[#154] Address review: always apply bootstrap.servers after merging o…

2f792e9

…verrides Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

igorsatsyuk requested a review from Copilot May 24, 2026 17:42

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 17:42 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread ...d-service/src/main/java/lt/satsyuk/distributed/audit/command/config/KafkaProducerConfig.java

[#154] Address review: use putIfAbsent for bootstrap.servers to allow…

9f6e72a

… producer-specific overrides Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

igorsatsyuk requested a review from Copilot May 24, 2026 17:51

Copilot started reviewing on behalf of igorsatsyuk May 24, 2026 17:51 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

igorsatsyuk self-assigned this May 24, 2026

igorsatsyuk merged commit c65b45d into main May 24, 2026
9 checks passed

Conversation

igorsatsyuk commented May 24, 2026

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants