ci: trigger SonarCloud on repository default branch#54
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes SonarCloud analysis not running on push because the workflow previously hardcoded refs/heads/main while the repository’s default branch is master. The SonarCloud step is now gated by a comparison against the repository’s configured default branch name, making it branch-name agnostic.
Changes:
- Updated the SonarCloud step
if:condition to run onpushonly whengithub.ref_namematchesgithub.event.repository.default_branch. - Preserved the existing
pull_requestcondition (still skippingdependabot[bot]).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧪 Test ResultsUnit Tests
Integration Tests
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Почему не запускался Sonar
В workflow шаг Sonar запускался на
pushтолько дляrefs/heads/main, а default branch репозитория —master.Что исправлено
.github/workflows/ci.ymlусловие обновлено с хардкода ветки на универсальную проверку:github.ref == ''refs/heads/main''github.ref_name == github.event.repository.default_branchРезультат
Шаг Sonar теперь запускается на
pushв актуальную default branch репозитория независимо от ее имени (master/main/другое).