fix(embed): create emitter inside iframe load event#14
Closed
ihatexcel wants to merge 3 commits into
Closed
Conversation
Emitter was created immediately after setting srcdoc, before the iframe document had loaded. With srcdoc, contentWindow can reference a stale browsing context during navigation, causing CHILD_READY to be missed or source-check to fail. The fix follows the pattern from the reference example: add a 'load' listener on the iframe, create the emitter inside it so contentWindow is stable and CHILD_READY is already queued for delivery. https://claude.ai/code/session_014XkyCi4sXUHdDjMstV2Pbt
New nav tab shows embed.html running in an iframe on the left, and its complete raw source fetched via fetch() displayed in a <pre> on the right. Both loaded lazily on first navigation. Source has a copy button. https://claude.ai/code/session_014XkyCi4sXUHdDjMstV2Pbt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emitter was created immediately after setting srcdoc, before the iframe document had loaded. With srcdoc, contentWindow can reference a stale browsing context during navigation, causing CHILD_READY to be missed or source-check to fail.
The fix follows the pattern from the reference example: add a 'load' listener on the iframe, create the emitter inside it so contentWindow is stable and CHILD_READY is already queued for delivery.
https://claude.ai/code/session_014XkyCi4sXUHdDjMstV2Pbt