Claude/remove broken commits lx33r#93
Merged
Merged
Conversation
- SqlDataTable: add CSV download button (visible on hover, exports all filtered/sorted rows with UTF-8 BOM for Excel compatibility) - room.tsx: replace RoomShell.Sidebar with custom sidebar div to suppress auto-positioned panel buttons; add DataPanelSidebarButton that renders the Sources toggle after the flex-1 spacer, grouped with Doc / Settings / ThemeSwitch instead of isolated at the very top https://claude.ai/code/session_016KJg349GAjQ3JkcTHpsjzS
Replace manual downloadCsv + hover button with QueryDataTableActionsMenu passed as footerActions to DataTablePaginated — the export button now sits right of the row count in the table footer, as provided by the @sqlrooms/data-table library. Also switch import to named export from package root instead of deep dist path. https://claude.ai/code/session_016KJg349GAjQ3JkcTHpsjzS
…export QueryDataTableActionsMenu uses useRoomStore internally and requires RoomStateProvider in the tree. When SqlDataTable is rendered inside ChildGroupModal (portaled outside <RoomShell>), this crashes with "Missing RoomStateProvider in the tree". Replace with a self-contained CSV download button that has no sqlrooms context dependency. https://claude.ai/code/session_01PqdRqnUJAB2ZRuYQd3qxmS
…ine CSV export" This reverts commit fe1b4ef.
…der context ChildGroupModal rendered outside <RoomShell> lacked RoomStateProvider, crashing any sqlrooms component (e.g. QueryDataTableActionsMenu) used inside child group cells. Moving it as a child of RoomShell gives it full access to the provider while Dialog still portals to document.body. https://claude.ai/code/session_01PqdRqnUJAB2ZRuYQd3qxmS
The [skip ci] tag in the dist-cdn commit message was preventing deploy.yml from running automatically after build-cdn.yml. Removing it lets the push to main chain into the deploy workflow as expected. https://claude.ai/code/session_01PqdRqnUJAB2ZRuYQd3qxmS
…w run GITHUB_TOKEN commits never trigger other workflows (GitHub anti-loop protection), so removing [skip ci] alone was not enough. Instead, explicitly dispatch deploy.yml on main at the end of build-cdn.yml. https://claude.ai/code/session_01PqdRqnUJAB2ZRuYQd3qxmS
build:cdn without --max-old-space-size=6144 causes OOM crash on GitHub Actions runners, silently skipping the deploy. Align with build-cdn.yml and deploy.yml which already set this flag. https://claude.ai/code/session_01PqdRqnUJAB2ZRuYQd3qxmS
DuckDB rejects queries ending with ';' in exportToCsv. Strip them inline before passing to QueryDataTableActionsMenu. Also removes test console.log. https://claude.ai/code/session_01PqdRqnUJAB2ZRuYQd3qxmS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.