hyphen-case config key support#13
Conversation
|
@shanielh thanks for the rebase. I had the same thoughts as @ceedubs (the guava dependency). Also we have the plan to rewrite the automatic case class readers based on shapeless. I am working on some shapeless+cat facilities that will make even more easier. Hopefully we'll see that soon. So for now I am going to leave this one on hold for a bit. Please check back later. |
There was a problem hiding this comment.
Not needed here, license is moved to project/Publish.scala
|
Travis Brown has done some recent work to support different cases in Circe. Since it uses Shapeless for derivation, it might be a good reference. |
|
@ceedubs, that looks quite similar, thanks for the hint. |
|
Please don't add huge dependencies such as Guava. |
|
Hyphen case would be super useful for my team. What work needs to be done to get this into Ficus? |
|
@colindean the plan was to take advantage of henkan to revamp the currently macro based auto case class mapping. However henkan is having a weird bug kailuowang/henkan#15. I would like to take advantage of @milessabin's SI2712 fix to simplify henkan before jumping into that bug fix though... |
|
Ah. I guess we'll stick to snake case for now! |
|
Okay. I gave up on using henkans here. So for this PR we just need to replace |
|
@kailuowang Great! I can do the changes, But before I do them, Maybe I should expose the |
|
@shanielh that's the exact conversation that Kai and I just had about this design. I think that's cleaner and more extensible. |
|
@joprice Hah, Ok, I believe I'll fix the PR tomorrow 👍 |
|
@shanielh thanks very much! |
|
Continued in #22 👍 |
7 participants
Just a rebase of ceedubs#12 to iheartradio/ficus