OTC-230: adds ESO support for cert-manager#207
Closed
hkailantzis wants to merge 28 commits intomainfrom
Closed
Conversation
mattef92
requested changes
Mar 30, 2026
Closed
…adjust conditions
…ger to latest version
hkailantzis
force-pushed
the
OTC-230-ESO-alignment
branch
from
7ffde39 to
1d5a689
Compare
hkailantzis
commented
Apr 1, 2026
hkailantzis
commented
Apr 1, 2026
hkailantzis
commented
Apr 1, 2026
mattef92
requested changes
Apr 8, 2026
mattef92
requested changes
Apr 10, 2026
mattef92
reviewed
Apr 10, 2026
…rt OTC DNS credentials keys renaming
mattef92
reviewed
Apr 13, 2026
mattef92
reviewed
Apr 13, 2026
mattef92
reviewed
Apr 13, 2026
| decodingStrategy: {{ $secretConfig.decodingStrategy | default $spec.decodingStrategy }} | ||
| metadataPolicy: {{ $secretConfig.metadataPolicy | default $spec.metadataPolicy }} | ||
| {{- end }} | ||
| --- |
Contributor
There was a problem hiding this comment.
Either this seems to be too much, or it's missing in the push secret
Contributor
Author
There was a problem hiding this comment.
went one step further to either have common values for all secrets (default) or override where desired. Was meant to be for pull mode only, but they're valid also for PushSecrets. will add the option also there.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
mattef92
requested changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
The common chart has to be merged before adjusting the cert-manager. Otherwise we need a follow-up PR regarding the chart.lock etc. of the cert-manager.
# mefker @ Mac in ~/code/github/charts/charts/cert-manager on git:OTC-230-ESO-alignment x [7:51:06]
$ helm template . -s templates/external-secrets.yaml -f values-test.yaml
Error: An error occurred while checking for chart dependencies. You may need to run `helm dependency build` to fetch missing dependencies: found in Chart.yaml, but missing in charts/ directory: common
# mefker @ Mac in ~/code/github/charts/charts/cert-manager on git:OTC-230-ESO-alignment x [7:51:24] C:1
$ helm dependency build
Error: the lock file (Chart.lock) is out of sync with the dependencies file (Chart.yaml). Please update the dependencies
Contributor
There was a problem hiding this comment.
This is also displayed in the Github Workflows, the pipeline fails
Contributor
There was a problem hiding this comment.
empty file should be omitted. Was this copy-paste from cert-manager or created by default via Helm create?
Contributor
Author
There was a problem hiding this comment.
its in every chart. I can remove it.
* feat(common): OTC-230: add opt-in for ESO resources in a common Lib helm chart * Auto update of README.md files * chores(*): add new lines --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
closing in favor of #215, which has cleaner history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes OTC-230.
#214 needs to be merged first.
IfNotExistsTested on new dev Playground (infrastructure-charts/local-charts):
Note: akyriako/cert-manager-webhook-opentelekomcloud#10 has been merged, and is available in v0.2.0. -> so dependency change back to original -> bumped Chart version and AppVersion to 1.17.5