Fix convert.quoted-printable-decode of lowercase hex digits - #189
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
The stream filter's nibble decoder accepts lowercase a-f via isxdigit() but decodes them as (*ps - 0x37), correct only for uppercase A-F. Bytes whose hex spelling uses a lowercase digit are silently corrupted (=cd decodes to 0xed, =0a to 0x2a). Decode lowercase with (*ps - 0x57).
Owner
Author
|
Promoted upstream: php#22870 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convert.quoted-printable-decode stream filter accepts lowercase hex digits (isxdigit() passes a-f) but its nibble math,
*ps >= 'A' ? *ps - 0x37 : *ps - 0x30, only handles uppercase, so a hex escape with a lowercase digit decodes to the wrong byte. quoted_printable_decode() handles lowercase correctly, so the filter and the function disagree.