All tasks #1
Open
All tasks #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
iljapavlovs
reviewed
Jun 22, 2017
| private int age; | ||
| private int size; | ||
| private String color; | ||
| public static final int CONST = 10; |
| package javaTraining.module3; | ||
|
|
||
| class Elephant extends Animal{ | ||
| String name = "Elephant"; |
Owner
There was a problem hiding this comment.
fields should always have access modifiers!
|
|
||
| Elephant(String name, int age, int size, String color) { | ||
| super(name, age, size, color); | ||
| this.name = name; |
Owner
There was a problem hiding this comment.
if you are setting fields in Parent class, then it will also belong to child class. There is no need in setting child class fields and parent class fields
|
|
||
| Lion(String name, int age, int size, String color) { | ||
| super(name, age, size, color); | ||
| this.name = name; |
Owner
There was a problem hiding this comment.
the same issue as for Elephant clas
| @@ -0,0 +1,7 @@ | |||
| package javaTraining.module4; | |||
|
|
|||
| public class WashingPlace { | |||
Owner
There was a problem hiding this comment.
why interface is inside of another class?
|
|
||
|
|
||
|
|
||
| class Animal extends Object{ |
Owner
There was a problem hiding this comment.
All classes in Java are extended from Object by default, hence no sense explicitly specifying it
|
|
||
| } | ||
|
|
||
| //Method Overriding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.