Prove the audit gate fails on a pull request (do not merge) - #32
Closed
illodev wants to merge 1 commit into
Closed
Conversation
Throwaway branch for T-0148's last criterion: "a pull request proves it fails there first". CI had shown the `audit` job running and passing on #30 and #31, which proves the wiring and the green path; the red path had only ever been run locally, and this repository does not treat a local run as proof of a pull request. So this pins `hono` to 4.12.33 deliberately — the version carrying GHSA-8j4g-w8fx-2239, which T-0222 overrode away — and nothing else. The `audit` job should go red. It also demonstrates T-0222's threshold change on one tree: this exact install exits 1 at `--audit-level=moderate` and 0 at `--audit-level=high`, which is the whole argument for lowering the floor to the one Dependabot alerts on. To be closed unmerged once the run is recorded on T-0148. Cards: T-0148 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3LTdq3mzMAQ98rwBegGjU
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Proof recorded on T-0148: the Closing unmerged, as intended. The advisory now surfaces on a pull request instead of on a tag push, which is what T-0148 asked for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. This PR exists to fail.
T-0148's last criterion is "a pull request proves it fails there first". PRs #30 and #31 showed the
auditjob running and passing, which proves the wiring and the green path. The red path had only been run locally, and this repository does not treat a local run as proof of a pull request — so here is the run.The diff pins
honoto4.12.33— the version carrying GHSA-8j4g-w8fx-2239, which #31 overrode away — and changes nothing else. Theauditjob should go red on thepnpm audit --audit-level=moderatestep.It also demonstrates #31's threshold change on a single tree: this exact install exits 1 at
--audit-level=moderateand 0 at--audit-level=high. That is the whole argument for aligning the floor with the one Dependabot alerts on, on one install rather than in prose.Will be closed unmerged as soon as the run is linked from T-0148.
🤖 Generated with Claude Code
https://claude.ai/code/session_01D3LTdq3mzMAQ98rwBegGjU