Closed
Conversation
Collaborator
|
Hey @ethanlee928 thanks for looking into this ! Will check thoroughly that everything is consistent with previous codebase. |
Collaborator
|
Please check out #389 - I tried to update all that needed to be done ! I'd be glad to have a second look from someone that worked on this - and have some real testing on your usecases to assert everything is nominal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #383.
Hi colpali team,
I found some time to work on upgrading
transformersto 5.0.0, which requires several code changes. This PR contains the current state of that work.@QuentinJGMace, sorry for jumping in on this upgrade. If you don't mind, could you help take a look and review the change when you have time? Also please feel free to take over. Thank you very much!
Summary
peftversionpaligemmachangesmodel.layerself.model.lm_head = torch.nn.Identity()as it causedAttributeError: Identity has no attribute weight.others
__init__to explicitly acceptimage_processorandtokenizerargumentsTesting Environment
3.12.11Ubuntu 22.04.5 LTS13.0580.95.05Testing Results
I ran the test suite with both versions.
Most failures appear to be unrelated to the transformers upgrade itself, but there are some new/different errors in this branch.
mainbranch:transformers==4.57.6This PR:
transformers==5.0.0