Lock scroll when dragged horizontally/vertically#47
Merged
Conversation
Contributor
Author
|
Added a similar approach for trackpad (scroll) events: I've updated the Codesandbox demo above. |
ilyashubin
reviewed
Jun 7, 2020
Owner
|
thanks for your PR! Very useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the interaction for mobile devices:
If
lockScrollOnDragDirectionis set to 'horizontal' and a horizontal drag is detected, default touch events will be prevented; if a vertical drag is detected, the drag position won't be updated.Vice versa if
lockScrollOnDragDirectionis set to 'vertical', eventhough I'm not sure if there is a use case for this.Goal is to increase UX for mobile devices since the
pointerDownPreventDefaultprop alone wasn't enough and the page jumps around if a scrollable element is being dragged (somewhat referencing #28)Codesandbox Demo