Skip to content

ci: make Docker Hub push conditional on configured secrets #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
im-pingo merged 1 commit into from
Aug 3, 2026
Merged

ci: make Docker Hub push conditional on configured secrets #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,20 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

# Push to Docker Hub only when credentials are configured; forks and
# repos without DOCKERHUB_* secrets still get a build-only smoke test.
- name: Check Docker Hub credentials
id: creds
run: |
if [ -n "${{ secrets.DOCKERHUB_USERNAME }}" ] && [ -n "${{ secrets.DOCKERHUB_TOKEN }}" ]; then
echo "available=true" >> "$GITHUB_OUTPUT"
else
echo "available=false" >> "$GITHUB_OUTPUT"
echo "DOCKERHUB_USERNAME/DOCKERHUB_TOKEN not set; building without push" >> "$GITHUB_STEP_SUMMARY"
fi

- name: Login to Docker Hub
if: steps.creds.outputs.available == 'true'
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
Expand All @@ -105,8 +118,8 @@ jobs:
uses: docker/build-push-action@v6
with:
context: .
push: true
platforms: linux/amd64,linux/arm64
push: ${{ steps.creds.outputs.available == 'true' }}
platforms: ${{ steps.creds.outputs.available == 'true' && 'linux/amd64,linux/arm64' || 'linux/amd64' }}
build-args: VERSION=${{ steps.version.outputs.sha_short }}
tags: |
impingo/liveforge:latest
Expand Down
Loading