fix: Added Favicon to the frontend#193
Open
Partharora07 wants to merge 3 commits into
Open
Conversation
Owner
|
@Partharora07 Please update the PR with screenshots or implementation proof so the changes can be verified easily. |
Author
|
Hi @imDarshanGK, Attached implementation proof/screenshots for verification.
While working on this issue, I noticed:
So I created a new Implementation includes:
|
imDarshanGK
requested changes
May 21, 2026
Owner
imDarshanGK
left a comment
There was a problem hiding this comment.
@Partharora07 Please share a screenshot of the favicon in the browser tab and the exact code path where it is implemented, not just the homepage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Added favicon support to the frontend by:
favicon.svgfrontend/index.htmlWhile working on this issue, I noticed that the
assets/icon.svgfile mentioned in the issue and README was not present in the current repository structure. The existingfrontend/public/favicon.icofile also appeared to be empty/invalid, so I generated and used a new SVG favicon instead -->>frontend/public/favicon.svg.Type of Change
Testing
pytest -q)Checklist
Hi @imDarshanGK, please review the PR when convenient. Also, since the repository currently does not contain the
assets/folder referenced in the README, let me know if you would also like me to update theREADME.mdaccordingly.Closes #172