Skip to content

fix: Added Favicon to the frontend#193

Open
Partharora07 wants to merge 3 commits into
imDarshanGK:mainfrom
Partharora07:Added-favicon
Open

fix: Added Favicon to the frontend#193
Partharora07 wants to merge 3 commits into
imDarshanGK:mainfrom
Partharora07:Added-favicon

Conversation

@Partharora07
Copy link
Copy Markdown

@Partharora07 Partharora07 commented May 20, 2026

Summary

Added favicon support to the frontend by:

  • created a working favicon.svg
  • added the favicon link inside frontend/index.html

While working on this issue, I noticed that the assets/icon.svg file mentioned in the issue and README was not present in the current repository structure. The existing frontend/public/favicon.ico file also appeared to be empty/invalid, so I generated and used a new SVG favicon instead -->> frontend/public/favicon.svg.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor

Testing

  • I ran backend tests (pytest -q)
  • I tested frontend behavior manually

Checklist

  • Code is readable and beginner-friendly
  • No fake or placeholder behavior introduced
  • Documentation updated if needed

Hi @imDarshanGK, please review the PR when convenient. Also, since the repository currently does not contain the assets/ folder referenced in the README, let me know if you would also like me to update the README.md accordingly.

Closes #172

@Partharora07 Partharora07 requested a review from imDarshanGK as a code owner May 21, 2026 08:13
@imDarshanGK
Copy link
Copy Markdown
Owner

@Partharora07 Please update the PR with screenshots or implementation proof so the changes can be verified easily.

@Partharora07
Copy link
Copy Markdown
Author

Hi @imDarshanGK,

Attached implementation proof/screenshots for verification.

  • First screenshot: current deployed version without favicon
  • Second screenshot: local implementation showing the newly added favicon working correctly in the browser tab

While working on this issue, I noticed:

  • the assets/ folder referenced in the issue/README was not present in the current repository
  • assets/icon.svg was missing
  • the existing frontend/public/favicon.ico file appeared to be empty/invalid

So I created a new favicon.svg file for the website and added the favicon link inside frontend/index.html.

Implementation includes:

  • frontend/public/favicon.svg
  • favicon link added in frontend/index.html
Screenshot 2026-05-21 at 3 45 41 PM Screenshot 2026-05-21 at 3 43 48 PM

Copy link
Copy Markdown
Owner

@imDarshanGK imDarshanGK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Partharora07 Please share a screenshot of the favicon in the browser tab and the exact code path where it is implemented, not just the homepage.

@kcprdev kcprdev mentioned this pull request May 21, 2026
13 tasks
@Partharora07
Copy link
Copy Markdown
Author

@imDarshanGK,

Attached the requested implementation proof:

  • browser tab screenshot showing the favicon working
  • code implementation screenshot showing the favicon link added in frontend/index.html
  • exact code path: frontend/public/favicon.svg
Screenshot 2026-05-21 at 7 47 30 PM Screenshot 2026-05-21 at 7 42 27 PM Screenshot 2026-05-21 at 7 31 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add favicon to the frontend HTML

2 participants