Skip to content

fix: improve markdown export spacing#408

Open
singhvishalkr wants to merge 5 commits into
imDarshanGK:mainfrom
singhvishalkr:fix/markdown-export-spacing
Open

fix: improve markdown export spacing#408
singhvishalkr wants to merge 5 commits into
imDarshanGK:mainfrom
singhvishalkr:fix/markdown-export-spacing

Conversation

@singhvishalkr

Copy link
Copy Markdown

Summary

  • add a shared Markdown formatter that separates exported messages with blank lines around ---
  • reuse the formatter for full-session and selected-message Markdown exports
  • avoid rendering empty raw sources values in selected-message Markdown output

Closes #93

Verification

  • python -m pytest backend/tests/test_api.py -k export -q
  • python -m pytest backend/tests -q
  • python -m py_compile backend/routes/export.py backend/tests/test_api.py
  • python -m black --check backend/routes/export.py
  • git diff --check

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

@singhvishalkr is attempting to deploy a commit to the Darshan's projects Team on Vercel.

A member of the Team first needs to authorize it.

@singhvishalkr

Copy link
Copy Markdown
Author

Local verification is green. The Vercel check appears to be blocked on preview authorization for the maintainer team, not on an application build or test failure.

@imDarshanGK imDarshanGK added invalid This doesn't seem right unassigned PR opened without issue assignment labels Jun 17, 2026
…pacing

# Conflicts:
#	backend/routes/export.py
#	backend/tests/test_api.py
@singhvishalkr

singhvishalkr commented Jun 26, 2026

Copy link
Copy Markdown
Author

Updated the branch with current main and resolved the export conflicts.

I also restored the selected-message lookup used by /api/export/messages, which was needed after the merge so the selected Markdown export path stays covered.

Local validation:

  • python -m py_compile backend/routes/export.py backend/tests/test_api.py backend/services/db_service.py
  • python -m pytest backend/tests/test_api.py -k export -q (9 passed, 39 deselected)
  • python -m black --check backend/routes/export.py
  • git diff --check origin/main -- backend/routes/export.py backend/tests/test_api.py backend/services/db_service.py

The remaining Vercel status is still preview authorization for the maintainer team.

@singhvishalkr

Copy link
Copy Markdown
Author

Updated the branch with current main and resolved the export conflict in backend/routes/export.py.

Validation:

  • python -m py_compile backend/routes/export.py backend/tests/test_api.py backend/services/db_service.py
  • python -m pytest backend/tests/test_api.py -k export -q (9 passed, 39 deselected)
  • python -m pytest backend/tests/test_api.py -q (48 passed)
  • python -m pytest backend/tests/test_csv_parser.py -q (2 passed)
  • python -m black --check backend/routes/export.py
  • git diff --check

I also tried the full backend test suite, but this local environment is missing optional test dependencies (chromadb, jsonschema) during collection. The focused export path and the newly merged CSV parser tests are passing locally.

The PR is mergeable again. The remaining Vercel status is still the maintainer-team preview authorization check.

@singhvishalkr

Copy link
Copy Markdown
Author

Updated the branch with current main and resolved the selected-message export conflict.

I kept the shared Markdown formatter and the newer safe_title filename behavior from main.

Validation:

  • python -m py_compile backend/routes/export.py backend/tests/test_api.py backend/services/db_service.py
  • python -m pytest backend/tests/test_api.py -k export -q (9 passed, 39 deselected)
  • python -m black --check backend/routes/export.py
  • git diff --check origin/main...HEAD

The remaining Vercel status still points to maintainer-team preview authorization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right unassigned PR opened without issue assignment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Export as Markdown missing line break between messages

2 participants