Imagekit Editor improvements #5
Conversation
SwarnimDoegar
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7663b96035
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else if (focus === "coordinates") { | ||
| // Handle coordinate-based focus | ||
| // x/y are top-left coordinates, xc/yc are center coordinates | ||
| if (x) transforms.x = x | ||
| if (y) transforms.y = y | ||
| if (xc) transforms.xc = xc | ||
| if (yc) transforms.yc = yc | ||
| if (coordinateMethod === "topleft") { | ||
| if (x) transforms.x = x |
There was a problem hiding this comment.
This new gating on coordinateMethod means existing transformations saved before this change (which only stored focus: "coordinates" plus x/y or xc/yc) will no longer emit any coordinates unless coordinateMethod is set. In that case the formatter will silently drop the stored coordinates and the resulting crop will fall back to default positioning. Consider defaulting the branch when coordinateMethod is undefined (e.g., use x/y if present, otherwise xc/yc) to keep backward compatibility. The same pattern appears again in the imageLayer formatter.
Useful? React with 👍 / 👎.
2 participants
No description provided.