Added missing callback when recording stops and the user don't give a…#243
Open
rpgzibralabs wants to merge 1 commit intoimaginary-cloud:masterfrom
Open
Conversation
…ny permissions to save the image in the Photo Library
NikKovIos
reviewed
Sep 5, 2022
NikKovIos
reviewed
Sep 5, 2022
rpgzibralabs
commented
Nov 7, 2022
Author
rpgzibralabs
left a comment
rpgzibralabs
left a comment
There was a problem hiding this comment.
I think the changes are Ok :)
|
Leaks could be, I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is missing a callback after the recording stops and the user don't give permissions to save the video to the Photo Library.
As the code is right now the callback is not performed when the user chooses not to give permissions for saving the video into the Photo Library. The callback is only called when the user gives permission and there's not callback to perform an action afterwards. It could be a good idea to maybe return an error when the writeFilesToPhoneLibrary flag is true and the user don't allows access to the Photo Library.