-
Notifications
You must be signed in to change notification settings - Fork 0
Major normalization fixes, figure making and CLI updates #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fce1271
cfcb6a5
bf84782
fe799e0
7fed06a
cfec1e7
007bf10
38914cf
80275c4
83e1c24
f2d31b0
803f842
dd54842
2f6f0fa
29c3422
e8a7574
92c3268
6ae5f51
6d354ad
b684d91
1d41859
dae89fa
522488f
2c4c7ca
6fba258
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -14,7 +14,9 @@ jobs: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| uses: actions/checkout@v4 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Installs | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| sudo apt update && sudo apt install -y libboost-program-options-dev libboost-iostreams-dev | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| sudo apt update && sudo apt install -y libboost-iostreams-dev | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| wget https://launchpad.net/ubuntu/+archive/primary/+files/libcli11-dev_2.6.1+ds-1_all.deb | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| sudo dpkg -i libcli11-dev_2.6.1+ds-1_all.deb | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+17
to
+19
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| sudo apt update && sudo apt install -y libboost-iostreams-dev | |
| wget https://launchpad.net/ubuntu/+archive/primary/+files/libcli11-dev_2.6.1+ds-1_all.deb | |
| sudo dpkg -i libcli11-dev_2.6.1+ds-1_all.deb | |
| sudo apt update && sudo apt install -y libboost-iostreams-dev libcli11-dev |
Copilot
AI
Mar 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normalization test block is commented out, but the repository still contains expected normalization outputs under test/test_normalization/out/. If normalization behavior changed intentionally, it’s better to update the expected outputs and keep the test enabled so regressions are caught, rather than disabling the check entirely.
| # -c test_normalization/in/simulations.tsv \ | |
| # -r test_normalization/in/reference.tsv \ | |
| # -i test_normalization/in/regions.bed \ | |
| # --out current_test_normalization_all_meth.out \ | |
| # --norm-det-out current_test_normalization_all_meth.norm.out \ | |
| # --all-meth | |
| # echo 'Diff expected vs produced normalized simple output' | |
| # diff test_normalization/out/simple.out \ | |
| # current_test_normalization.out | |
| # diff test_normalization/out/simple_all_meth.out \ | |
| # current_test_normalization_all_meth.out | |
| # echo 'Diff expected vs produced normalized detailed output' | |
| # diff test_normalization/out/detailed.out \ | |
| # current_test_normalization.norm.out | |
| # diff test_normalization/out/detailed_all_meth.out \ | |
| # current_test_normalization_all_meth.norm.out | |
| - name: Test normalization | |
| if: always() | |
| run: | | |
| cd test | |
| ../method/build/yamet \ | |
| -c test_normalization/in/simulations.tsv \ | |
| -r test_normalization/in/reference.tsv \ | |
| -i test_normalization/in/regions.bed \ | |
| --out current_test_normalization.out \ | |
| --norm-det-out current_test_normalization.norm.out | |
| ../method/build/yamet \ | |
| -c test_normalization/in/simulations.tsv \ | |
| -r test_normalization/in/reference.tsv \ | |
| -i test_normalization/in/regions.bed \ | |
| --out current_test_normalization_all_meth.out \ | |
| --norm-det-out current_test_normalization_all_meth.norm.out \ | |
| --all-meth | |
| echo 'Diff expected vs produced normalized simple output' | |
| diff test_normalization/out/simple.out \ | |
| current_test_normalization.out | |
| diff test_normalization/out/simple_all_meth.out \ | |
| current_test_normalization_all_meth.out | |
| echo 'Diff expected vs produced normalized detailed output' | |
| diff test_normalization/out/detailed.out \ | |
| current_test_normalization.norm.out | |
| diff test_normalization/out/detailed_all_meth.out \ | |
| current_test_normalization_all_meth.norm.out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow installs CLI11 via a hard-coded Launchpad .deb +
dpkg -i, which is brittle and can break when the URL/version changes or dependencies are missing. Prefersudo apt install -y libcli11-dev(as intar.yml) or add the appropriate repository instead of downloading a .deb directly.