fix(files): replace native confirm with modal dialog for file deletion#211
Open
Git-Shubham14 wants to merge 1 commit into
Open
fix(files): replace native confirm with modal dialog for file deletion#211Git-Shubham14 wants to merge 1 commit into
Git-Shubham14 wants to merge 1 commit into
Conversation
👷 Deploy request for file-sharingsystem pending review.Visit the deploys page to approve it
|
|
@Git-Shubham14 is attempting to deploy a commit to the imanchalsingh Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Summary
closes #190
Description
Replaces the native browser
window.confirm()popup with a styled confirmation modal dialog before deleting a file in My Files. The modal shows the file name, a red irreversibility warning, and Cancel/Delete buttons — matching the existing modal design system used across the app.Type of Change
Checklist
export defaultinvalidateEnv.jscrashes the server, preventing login)Pre-existing Issues (not caused by this PR)
validateEnv.jshas duplicateexport defaultcrashing the server (blocks login/signup locally)Cannot find name 'Check'in MyFiles.tsx — from a pending PR on a separate branchbaseUrldeprecated warning intsconfig.app.json— pre-existing repo issueCode can be verified by reviewing the JSX in MyFiles.tsx or on the live Vercel deployment once merged.