fix(upload): parse multipart form fields before loadUploadSessionForChunk to fix req.body undefined#212
Open
Git-Shubham14 wants to merge 1 commit into
Conversation
…hunk to fix req.body undefined
👷 Deploy request for file-sharingsystem pending review.Visit the deploys page to approve it
|
|
@Git-Shubham14 is attempting to deploy a commit to the imanchalsingh Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hii @imanchalsingh, please check the pr and let me know is it successfully works or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #203
The chunk upload route was failing with a 500 error because
req.bodywasundefinedwhenloadUploadSessionForChunktried to destructuresessionIdandchunkIndexfrom it.Root Cause:
The client sends chunk data as
multipart/form-data(FormData). Multer only parsesreq.bodywhen it runs — butloadUploadSessionForChunkwas executing before multer, soreq.bodywas always empty at that point.Fix:
Added a
fieldParserusingmulter().none()as the first middleware inchunkUploadMiddleware. This parses the multipart form fields (sessionId,chunkIndex) intoreq.bodybeforeloadUploadSessionForChunkruns, without consuming the file chunk itself.Type of Change
Checklist
passwordAttemptLimiterinrateLimiter.jsand missingrate-limit-redispackage preventing server from starting)Pre-existing Issues Found (not caused by this PR)
rateLimiter.js— duplicatepasswordAttemptLimiterdeclaration (can be raised as separate issue)rate-limit-redispackage missing from dependencies (Redis not configured locally)validateEnv.js— duplicateexport default(already fixed in this branch)