fix(ui): add dynamic per-page browser tab titles based on route#220
Open
Git-Shubham14 wants to merge 1 commit into
Open
fix(ui): add dynamic per-page browser tab titles based on route#220Git-Shubham14 wants to merge 1 commit into
Git-Shubham14 wants to merge 1 commit into
Conversation
👷 Deploy request for file-sharingsystem pending review.Visit the deploys page to approve it
|
|
@Git-Shubham14 is attempting to deploy a commit to the imanchalsingh Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #194
Every page previously showed the same static browser tab title "ShareVault - File Sharing System" regardless of the current route. This made it impossible to distinguish multiple open tabs and hurt basic SEO.
Changes
client/src/App.tsxDynamicTitlecomponent that listens to route changes viauseLocationrouteTitlesmap covering all routes in the appdocument.titleon every navigation/share/:id→ "Shared File — ShareVault" and/s/:token→ "Accessing File — ShareVault"<DynamicTitle />at the top of the app above<Routes>Before
All pages: "ShareVault - File Sharing System"
After
/→ "ShareVault — Secure File Sharing"/login→ "Login — ShareVault"/register→ "Register — ShareVault"/home/myfiles→ "My Files — ShareVault"/home/analytics→ "Analytics — ShareVault"/home/favorites→ "Favorites — ShareVault"/home/shares→ "Shares — ShareVault"/home/settings→ "Settings — ShareVault"/share/:id→ "Shared File — ShareVault"Type of Change
Checklist