Conversation
👷 Deploy Preview for imarc-pronto processing.
|
There was a problem hiding this comment.
Pull request overview
This PR performs formatting and linting updates across the Pronto codebase. It reorganizes the directory structure from imported/ to core/, adds a new @ alias for cleaner imports, and applies prettier and stylelint formatting throughout SCSS, HTML, and JavaScript files.
Changes:
- Renamed
resources/styles/imported/toresources/styles/core/and updated all import references - Added Vite alias
@pointing toresources/stylesfor cleaner imports - Applied prettier formatting (hex colors expanded to 6 digits, consistent quotes, spacing)
- Added stylelint configuration and applied CSS/SCSS linting rules
- Formatted HTML files with self-closing tags and consistent indentation
Reviewed changes
Copilot reviewed 143 out of 154 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.js | Updated alias from @imarc/pronto to @ for styles directory |
| stylelint.config.mjs | New stylelint configuration with SCSS rules |
| package.json | Added prettier, stylelint, postcss-scss dependencies |
| resources/styles/core/ | Renamed from imported/, contains base styles and utilities |
| resources/styles/**/*.scss | Applied formatting: 6-digit hex, single quotes, consistent spacing |
| resources/styles/**/*.html | Applied formatting with self-closing tags and indentation |
| resources/js/ | Applied prettier formatting to Vue and JS files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | ||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a><li> | ||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | ||
| <li></li> |
There was a problem hiding this comment.
Empty list items (<li></li>) have been added throughout the navigation HTML. These appear to be leftover artifacts from the formatter that previously had closing tags on separate lines (e.g., <li>). Empty list items are invalid HTML and serve no purpose - they should be removed.
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | ||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a><li> | ||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | ||
| <li></li> |
There was a problem hiding this comment.
Empty list items (<li></li>) have been added. These are invalid HTML artifacts from the formatter - remove them.
| @@ -88,7 +90,8 @@ | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a><li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| </template> | |||
| @@ -101,38 +104,35 @@ | |||
| <div class="grid -columns-3"> | |||
| <div class="cell"> | |||
| <h3>Heading</h3> | |||
| <p> | |||
| Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae | |||
| </p> | |||
| <p>Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae</p> | |||
| <ul class="dropdown__list"> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a><li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| <div class="cell"> | |||
| <h3>Heading</h3> | |||
| <p> | |||
| Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae | |||
| </p> | |||
| <p>Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae</p> | |||
| <ul class="dropdown__list"> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a><li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| <div class="cell"> | |||
| <h3>Heading</h3> | |||
| <p> | |||
| Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae | |||
| </p> | |||
| <p>Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae</p> | |||
| <ul class="dropdown__list"> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a><li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| </div> | |||
| @@ -148,7 +148,8 @@ <h3>Heading</h3> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a><li> | |||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | |||
| <li></li> | |||
There was a problem hiding this comment.
Empty list items (<li></li>) throughout this file are invalid HTML and should be removed.
| @@ -17,14 +26,23 @@ | |||
| <li class="navigation__item" v-directionals> | |||
| <p-openable class="navigation__button" label="Centered Dropdown" :close-on-blur="false" :hover-or-click="true"> | |||
| <template #default> | |||
| <div class="navigation__dropdown -center"> | |||
| <ul> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Amet porro.</span></a></li> | |||
| <li><a href=""><span>Ipsum dolorem</span></a><li> | |||
| </ul> | |||
| </div> | |||
| <div class="navigation__dropdown -center"> | |||
| <ul> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Amet porro.</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Ipsum dolorem</span></a> | |||
| </li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| </template> | |||
| </p-openable> | |||
| </li> | |||
| @@ -34,38 +52,59 @@ | |||
| <div class="navigation__dropdown grid -columns-3"> | |||
| <div class="cell"> | |||
| <h3>Heading</h3> | |||
| <p> | |||
| Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae | |||
| </p> | |||
| <p>Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae</p> | |||
| <ul> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Amet porro.</span></a></li> | |||
| <li><a href=""><span>Ipsum dolorem</span></a><li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Amet porro.</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Ipsum dolorem</span></a> | |||
| </li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| <div class="cell"> | |||
| <h3>Heading</h3> | |||
| <p> | |||
| Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae | |||
| </p> | |||
| <p>Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae</p> | |||
| <ul> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Amet porro.</span></a></li> | |||
| <li><a href=""><span>Ipsum dolorem</span></a><li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Amet porro.</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Ipsum dolorem</span></a> | |||
| </li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| <div class="cell"> | |||
| <h3>Heading</h3> | |||
| <p> | |||
| Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae | |||
| </p> | |||
| <p>Adipisicing obcaecati tempora qui ullam voluptates beatae? Assumenda soluta quae</p> | |||
| <ul> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Amet porro.</span></a></li> | |||
| <li><a href=""><span>Ipsum dolorem</span></a><li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Amet porro.</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Ipsum dolorem</span></a> | |||
| </li> | |||
| <li></li> | |||
| </ul> | |||
| </div> | |||
| </div> | |||
| @@ -77,10 +116,19 @@ <h3>Heading</h3> | |||
| <template #default> | |||
| <div class="navigation__dropdown -rightAligned"> | |||
| <ul> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Consectetur asperiores</span></a></li> | |||
| <li><a href=""><span>Amet porro.</span></a></li> | |||
| <li><a href=""><span>Ipsum dolorem</span></a><li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Consectetur asperiores</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Amet porro.</span></a> | |||
| </li> | |||
| <li> | |||
| <a href=""><span>Ipsum dolorem</span></a> | |||
| </li> | |||
| <li></li> | |||
There was a problem hiding this comment.
Empty list items (<li></li>) throughout this file are invalid HTML and should be removed.
| <use href="/main-icons-sprite.svg#clock" /></svg | ||
| >15 Minute Read |
There was a problem hiding this comment.
The SVG closing tag has been incorrectly split, breaking HTML syntax. Should be: <svg class="card__metaIcon"><use href="/main-icons-sprite.svg#clock" /></svg>15 Minute Read
| <a class="link" href="" | ||
| >Praesentium ex architecto <svg viewBox="0 0 18 12"><use href="/main-icons-sprite.svg#arrow-right" /></svg | ||
| ></a> |
There was a problem hiding this comment.
The closing > for the <a> tag has been incorrectly placed on a separate line, breaking HTML syntax. Should be: <a class="link" href="">Praesentium ex architecto <svg>...</svg></a>
resources/_preview.html
Outdated
| style=" | ||
| $ { | ||
| component.url?.match(/atoms|molecules/)?'padding: 2rem': ''; | ||
| } | ||
| " |
There was a problem hiding this comment.
Template literal syntax in the style attribute is incorrect. Should be plain HTML without $ or template literal syntax: style="padding: 2rem" or similar.
| style=" | |
| $ { | |
| component.url?.match(/atoms|molecules/)?'padding: 2rem': ''; | |
| } | |
| " | |
| style="padding: 2rem" |
| <li class="dropdown__item"><a href="" class="dropdown__link">Consectetur asperiores</a></li> | ||
| <li class="dropdown__item"><a href="" class="dropdown__link">Amet porro.</a></li> | ||
| <li class="dropdown__item"><a href="" class="dropdown__link">Ipsum dolorem</a></li> | ||
| <li></li> |
There was a problem hiding this comment.
Empty list item (<li></li>) is invalid HTML and should be removed.
| <li></li> |
| main = putStrLn "Hello World!"</pre | ||
| > |
There was a problem hiding this comment.
The <pre> closing tag has been incorrectly split across two lines. This breaks the HTML syntax and should be on the same line: main = putStrLn "Hello World!"</pre>
| <use href="/main-icons-sprite.svg#clock" /></svg | ||
| >Posted Aug 12, 2023 by <a href="#" class="card__metaLink">Daphne Writesposts</a> |
There was a problem hiding this comment.
The SVG closing tag has been incorrectly split across two lines, breaking HTML syntax. Should be: <svg class="card__metaIcon"><use href="/main-icons-sprite.svg#clock" /></svg>Posted Aug...
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 148 out of 158 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.