Open
Conversation
A method to load data after a trained forest and start prediction mode
Author
|
Hello @mnwright could you have a look please? |
Author
|
Hi @mnwright could you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a small addition to the Forest class: a
loadDataForPredictionmethod to load data for an already trained Forest without having to call theForest::initRmethod.I am proposing this because I am trying to wrap the C++ core of Ranger into OpenTURNS (I have a prototype here) and this feature would be useful.
Maybe it could also help solve #133 (comment)
One thing I am wondering is whether
Forest::initInternalneeds to be called in prediction mode. I madeForest::loadDataForPredictioncall it to try to be on the safe side, but I am not sure whether it is necessary.