Skip to content

docs(testbench-vscode-extension): version 0.5.0#4

Closed
egegirit wants to merge 8 commits intoimbus:mainfrom
egegirit:docs/testbench-vscode-extension-v0.5.0
Closed

docs(testbench-vscode-extension): version 0.5.0#4
egegirit wants to merge 8 commits intoimbus:mainfrom
egegirit:docs/testbench-vscode-extension-v0.5.0

Conversation

@egegirit
Copy link
Copy Markdown

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

@laura-els laura-els left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would avoid to only use lists instead of plain text paragraphs. I think in the Getting Started chapter it makes sense. But for the user-guide-like pages, it's better to use whole sentences instead of bullet points (e.g. like I suggested in this comment). This will also look better when screenshots are inserted.

Comment thread docusaurus/testbench-vs-code-extension_versioned_docs/version-0.5.0/intro.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

@egegirit
Copy link
Copy Markdown
Author

egegirit commented Apr 2, 2026

In addition to the review findings, I also added images that were used for README.md to the docusaurus pages.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

@laura-els laura-els left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general comment about the GIFs: I know that GIFs are used also in the readme of the extension and I like the mini-demos they provide, but I find them quite distracting. It's hard to focus on the text when something is continuously moving elsewhere on the page. I don't think it's accessible either. If it does not take too much time, it would be good to have a way to pause and replay the GIFs/videos instead of having them play all the time.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@egegirit
Copy link
Copy Markdown
Author

I've addressed the review comments (hopefully I didn't miss any), and also replaced the GIFs with playable video (webm and mp4 as fallback for older browsers).

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@Snooz82 Snooz82 closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants