fix: close InputStream from Profile.assets() in PfShell.key() - #2
Open
imedfan wants to merge 2 commits into
Open
fix: close InputStream from Profile.assets() in PfShell.key()#2imedfan wants to merge 2 commits into
imedfan wants to merge 2 commits into
Conversation
Wrap the asset stream in a try-with-resources block so the InputStream returned by Profile.assets().get(path) is closed deterministically, and fetch it only once instead of twice. https://claude.ai/code/session_01JMZzw7mA6JumUiPuS8QEMb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the resource leak described in yegor256#2324.
PfShell.key()retrieved the SSH private key fromProfile.assets()without closing the returnedInputStream. It also calledassets().get(path)twice — once for the null check and once to read the stream — so neither stream was closed. SinceProfile.assets()returns raw streams owned by the caller andIOUtils.toString()does not close them, this leaked file descriptors / memory.Changes
nullcheck on the single fetched stream.Profile.ConfigException extends RuntimeException, so the not-found exception still propagates without being re-wrapped by theIOExceptioncatch — behavior is preserved.Test plan
mvn compilesucceeds.https://claude.ai/code/session_01JMZzw7mA6JumUiPuS8QEMb
Generated by Claude Code