Problems in rename - encode_images_and_json.py#2
Open
Dragost37 wants to merge 1 commit intoimmersal:mainfrom
Open
Problems in rename - encode_images_and_json.py#2Dragost37 wants to merge 1 commit intoimmersal:mainfrom
Dragost37 wants to merge 1 commit intoimmersal:mainfrom
Conversation
Originally, the script only renamed image files based on metadata from their JSON files, leaving the JSON files unchanged. This caused issues when tools (localize test script) expected filenames to match. The updated version fixes that by renaming both the image and its JSON together. It also adds checks to avoid errors if files are missing or already renamed, making the script safer to run multiple times without breaking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the script only renamed image files based on metadata from their JSON files, leaving the JSON files unchanged. This caused issues when tools (localize test script) expected filenames to match. The updated version fixes that by renaming both the image and its JSON together. It also adds checks to avoid errors if files are missing or already renamed, making the script safer to run multiple times without breaking.
This solved my problem might be useful to you, might not. You decide. :)