Conversation
…e` dependency to build on 1.80.0 Our old nightly (1.65) pins `time-macros` to an old version, which requires `time` to stay on an old version. But since 1.80 broke `time` (due to time-rs/time#693 and rust-lang/rust#127343), we need to update `time`. Doing this requires `time-macros` to be upgraded, which requires at least rust 1.67. There's an old PR, #811, for this, but it needs rebasing. So for now, removing `git-testament` and its `time` dependency is simpler, and we can add it back later once we update to a newer nightly.
Contributor
Author
|
@chrysn, feel free to review and/or test this. Hopefully it works for everything you need. |
thedataking
approved these changes
Aug 28, 2024
fw-immunant
approved these changes
Aug 28, 2024
Contributor
fw-immunant
left a comment
fw-immunant
left a comment
There was a problem hiding this comment.
LGTM, thanks for untangling these dep issues.
This was referenced Aug 28, 2024
Closed
dgherzka
pushed a commit
to dgherzka/c2rust
that referenced
this pull request
Sep 4, 2024
…e` dependency to build on 1.80.0 (immunant#1115) * Fixes immunant#1109. Our old nightly (1.65) pins `time-macros` to an old version, which requires `time` to stay on an old version. But since 1.80 broke `time` (due to time-rs/time#693 and rust-lang/rust#127343), we need to update `time`. Doing this requires `time-macros` to be upgraded, which requires at least rust 1.67. There's an old PR, immunant#811, for this, but it needs rebasing. So for now, removing `git-testament` and its `time` dependency is simpler, and we can add it back later once we update to a newer nightly. With this fix, both `cargo build -p c2rust` (the pinned nightly) and `cargo +stable build -p c2rust` (1.80.1) now work. If this is good, and once we merge this, we'll release a new version with the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our old nightly (1.65) pins
time-macrosto an old version, which requirestimeto stay on an old version. But since 1.80 broketime(due to time-rs/time#693 and rust-lang/rust#127343), we need to updatetime. Doing this requirestime-macrosto be upgraded, which requires at least rust 1.67. There's an old PR, #811, for this, but it needs rebasing. So for now, removinggit-testamentand itstimedependency is simpler, and we can add it back later once we update to a newer nightly.With this fix, both
cargo build -p c2rust(the pinned nightly) andcargo +stable build -p c2rust(1.80.1) now work.If this is good, and once we merge this, we'll release a new version with the fix.