Initial (hacky) version of PDG snapshot testing for analysis/test#505
Initial (hacky) version of PDG snapshot testing for analysis/test#505
analysis/test#505Conversation
… the one that (purposefully I think) segfaults.
Yes, I believe so. |
oinoom
left a comment
There was a problem hiding this comment.
Yay! Great start, this is already a much-needed improvement. I'd love to add this to the pipeline if it's not already there.
|
@aneksteind, it'll be added to the CI pipeline once #483 lands, as that adds |
|
Also, just a note, if the snapshot tests fail, you can review changes with |
Yep, already making use of this for the new PDG features I'm working on! :) |
|
Awesome! Yeah, sorry for taking a while. I probably could've implemented this very bare bones version a bit earlier. |
This is an initial (currently quite hacky) version of PDG snapshot testing for
analysis/test. Currently it just shells out to./scripts/pdg.shand reads the produced (byc2rust-pdg)analysis/test/pdg.log. I intend to improve this a lot (not shell out, but instead invoke library functions inc2rust_pdgandc2rust_dynamic_instrumentation), but I think it's useful to get a working version running so that we are aware of any PDG changes that occur and can unblock anyone else waiting for this to get more aggressive with changes.Also, the
snapshots/*.snapfiles need to be committed, right?