chore: update game bridge to 2.12.6 #659
Open
+1,232
−361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattb8
reviewed
Feb 4, 2026
rodrigo-fournier-immutable
force-pushed
the
chore/update-game-bridge-2.12.6
branch
from
92a1033 to
b6ba396
Compare
nattb8
reviewed
Feb 4, 2026
| time.sleep(5) | ||
| print("Logged out") | ||
|
|
||
| self.altdriver.stop() |
Collaborator
There was a problem hiding this comment.
Keep logout and wait for authenticated screen so that we test logout too
rodrigo-fournier-immutable
force-pushed
the
chore/update-game-bridge-2.12.6
branch
from
b6ba396 to
7ea6a56
Compare
rodrigo-fournier-immutable
force-pushed
the
chore/update-game-bridge-2.12.6
branch
4 times, most recently
from
08a7b92 to
7e7bc50
Compare
…bility Add controlled browser logout for macOS to handle deep-link dispatch issues introduced by Chrome 137 code-splitting changes. Changes: - Add logout_with_controlled_browser() in test_mac_helpers.py - Add get_logout_url_from_unity_logs() to monitor Unity logs - Add get_product_name() to extract product name from ProjectSettings - Update logout() method to use controlled browser approach - Manually trigger immutablerunner://logout deep-link via 'open' command - Reduce Windows login timeout from 90s to 30s This matches the Windows implementation and resolves logout timeouts caused by Chrome 137's increased code-splitting affecting protocol handler reliability.
rodrigo-fournier-immutable
force-pushed
the
chore/update-game-bridge-2.12.6
branch
from
7e7bc50 to
dc755d5
Compare
Windows: - Extract returnTo deep-link from logout URL - Write deep-link to Windows Registry for Unity to process - Fixes app crash by ensuring logout callback is received macOS: - Kill existing Brave processes before launching with debugging port - Prevents 'cannot connect to chrome at localhost:9222' error - Ensures controlled logout can connect to browser Both platforms now properly dispatch immutablerunner://logout deep-link back to Unity after browser logout completes.
rodrigo-fournier-immutable
force-pushed
the
chore/update-game-bridge-2.12.6
branch
from
6041098 to
1b391d9
Compare
Extract tab closing logic into reusable methods: - Windows: close_all_browser_tabs() in test_windows_helpers.py - macOS: close_all_browser_tabs() method in MacTest class Call in setUpClass to ensure clean browser state before test suite runs. This prevents leftover tabs from previous runs from interfering with tests. Also refactor stop_browser() to use the new tab closing methods.
…) and tab cleanup (macOS) Windows: - Add logic to click 'click here' link on logout page - Tries multiple selectors (partial link text, link text, xpath) - Falls back to registry deep-link dispatch if link not found macOS: - Call close_all_browser_tabs() in logout() after launch_browser() - Ensures clean browser state before logout interaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update game bridge (build from ts-immutable-sdk version 2.12.6)