Rename boolean SQL columns to is_/has_ convention (#227)#41
Merged
Conversation
…JS props unchanged)
…or is_/has_ boolean rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames every boolean SQL column in the schema to the
is_*/has_*predicate convention (InspectorHub#227), via nativeALTER TABLE … RENAME COLUMN(no table rebuild, no D1 FK-drop risk), and adds alint:naminggate.Zero code ripple
Only the
integer('<sql_name>', …)string changes; the camelCase Drizzle JS property names are unchanged, so services/API/frontend are untouched. The only consumers touched are hand-written SQL test fixtures + schema-.nameassertions.What changed
active→is_active,pdf_show_footer→is_pdf_footer_shown,sender_attached→has_sender_attached,notify_on_referral→is_referral_notification_enabled).migrations/0001_boolean_columns_is_has.sql— oneRENAME COLUMNper column; drizzle snapshot/journal chained (db:generatereports "No schema changes").scripts/check-naming.mjs+ unit test —lint:naminggate wired intolint.docs/superpowers/notes/2026-07-14-oi-boolean-rename-map.md— authoritative old→new map.tenant_configs/usersDDL fixtures +.nameassertions.Verification
lint(incl.lint:naming) ✓ ·db:checkno drift ✓ ·test:unit3091 passed ✓ ·test:workers✓RENAME COLUMNkeeps all data (verified on remote apply).