Fix dead time check in make_sinc_pulse.py when return_gz is True#375
Open
dabosch wants to merge 3 commits intoimr-framework:masterfrom
Open
Fix dead time check in make_sinc_pulse.py when return_gz is True#375dabosch wants to merge 3 commits intoimr-framework:masterfrom
dabosch wants to merge 3 commits intoimr-framework:masterfrom
Conversation
Intended behavior: modify RF delay iff RF pulse delay is smaller than dead time. Old actual behavior: modify RF delay if RF pulse or slice selection gradient has delay smaller than dead time. The ramp-up time of slice selection was not taken into account. Fixed by moving dead time check to a later position in the code, after slice selection gradient is generated and RF pulse is positioned correctly. If required, gz delay is adjusted as well.
Author
|
To clarify: it might be sufficient to modify the warning logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where RF delay is increased even when ramp-up time of the slice selection gradient gives sufficient delay.
Intended behavior: increase RF delay iff RF pulse delay is smaller than dead time.
Old actual behavior: modify RF delay if RF pulse or slice selection gradient has delay smaller than dead time.
In other words, the ramp-up time of the slice selection was not taken into account when checking if RF delay is sufficient.
Fixed by moving dead time check to a later position in the code, after slice selection gradient is generated and RF pulse is positioned correctly. If required, gz delay is adjusted as well.