refactor(setting): 改了点设置 优化显示效果 更改字段名 #780
Conversation
把两个模态框改为了相近的形式，名称也统一了
起码好点了 不是吗.jpg
我说这里怎么回事呢，有个遗漏代码？
Summary of ChangesHello @MoYingJi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求对应用程序的设置进行了重要的重构，主要集中在评论和歌词排除功能上。这些更改旨在通过提供更直观、更有组织的界面来配置这些功能，从而增强用户体验，同时通过标准化命名约定和整合组件来提高代码可维护性。此外，它还为各种设置项引入了有用的提示信息，并确保某些功能正确地限定在Electron环境中。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| keywords: settingStore.excludeCommentKeywords || [], | ||
| regexes: settingStore.excludeCommentRegexes || [], |
There was a problem hiding this comment.
导出功能目前导出的是 Pinia store 中已保存的数据，而不是当前界面上（可能未保存）的规则。这可能会导致用户在编辑规则后导出时，得到的是旧的规则，从而产生困惑。建议修改为导出当前界面 filterKeywords 和 filterRegexes 的值，以符合用户预期。
keywords: filterKeywords.value || [],
regexes: filterRegexes.value || [],
There was a problem hiding this comment.
我保持了原来的逻辑没动吧 觉得需要也可以改
| input.onchange = (e: any) => { | ||
| const file = e.target.files[0]; | ||
| if (!file) return; |
There was a problem hiding this comment.
在 TypeScript 中，应尽量避免使用 any 类型。这里的事件参数 e 可以被更精确地类型化，以增强代码的类型安全性和可读性。
input.onchange = (event: Event) => {
const file = (event.target as HTMLInputElement).files?.[0];
if (!file) return;
| keywords: settingStore.excludeLyricsUserKeywords || [], | ||
| regexes: settingStore.excludeLyricsUserRegexes || [], |
There was a problem hiding this comment.
与评论排除模块类似，此处的导出功能也是直接从 Pinia store 中读取数据。为了提供更直观的用户体验，建议导出当前界面中的（可能未保存的）规则，即 filterKeywords 和 filterRegexes 的值。
keywords: filterKeywords.value || [],
regexes: filterRegexes.value || [],
| input.onchange = (e: any) => { | ||
| const file = e.target.files[0]; | ||
| if (!file) return; |
There was a problem hiding this comment.
为了提高代码的类型安全，建议为事件参数 e 提供更具体的类型，而不是使用 any。
input.onchange = (event: Event) => {
const file = (event.target as HTMLInputElement).files?.[0];
if (!file) return;
|
其实担心的是我把排除评论和歌词的模态框都调整成这样的统一样式了，不知道好不好的说 
|
好的不得了（ |
2 participants
具体可以看每一个 Commit