test(grpo): document current surrogate ratio semantics - #438
Open
yaoyao12345666 wants to merge 1 commit into
Open
test(grpo): document current surrogate ratio semantics#438yaoyao12345666 wants to merge 1 commit into
yaoyao12345666 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds focused CPU tests that document the current GRPO surrogate semantics:
This changes tests only, not the GRPO implementation.
Related issue
Fixes #66
Type of change
How was it tested?
python -m pytest tests/test_losses_rewards_cpu.py -q(13 passed)ruff check tests/test_losses_rewards_cpu.py --no-cacheruff format --check tests/test_losses_rewards_cpu.py --no-cacheThe full CPU suite was attempted on Windows, but collection imports Linux-only
pty/termioscode. AReno officially targets Linux/WSL2; CI is the authoritative full-suite result.Checklist
pytest tests/ -k cpu) - blocked locally by the Windows/Linux collection boundary described above.