feat(dashboard): preview launcher validation and command - #449
Open
Dayuxiaoshui wants to merge 1 commit into
Open
feat(dashboard): preview launcher validation and command#449Dayuxiaoshui wants to merge 1 commit into
Dayuxiaoshui wants to merge 1 commit into
Conversation
Author
|
cc @xsuler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a focused preview and validation step to the dashboard train and serve launcher before a subprocess is submitted.
The launcher now:
The change adds no dependency, external database, hosted service, or public CLI option. Existing train and serve command builders remain available, and the packaged dashboard assets are rebuilt with the new launcher UI.
Related issue
Fixes #269
Issue: #269
Type of change
How was it tested?
Focused CPU and existing train CLI configuration tests:
Result:
91 passed.Dashboard production build:
Result: Vite transformed 1,830 modules and completed the production build.
The running dashboard API was also probed with deterministic local references:
The broader CPU suite was run with:
Result:
401 passed, 5 failed. The five failures are environment-sensitive and outside the changed launcher paths: one writable-path diagnostic expectation, two CUDA-visible-device assumptions, and two distributed NCCL/Gloo subprocess tests that attempted to use the same visible GPU. No GPU training or serving run was performed.Checklist
pytest tests/ -k cpu).