refactor(trainers): share auxiliary-role lifecycle - #452
Open
yuetongz417 wants to merge 1 commit into
Open
Conversation
Extract backend role initialization, cleanup, and validated log-probability scoring into reusable role-aware trainer classes. Migrate DPO and PPO without changing their algorithm behavior, providing a shared foundation for teacher-scored workflows such as OPD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the auxiliary model-role lifecycle shared by DPO and PPO into reusable role-aware trainer classes.
The new
RoleAwareTrainerMixincentralizes:ensure_roles;RoleAwarePolicyTrainercombines this shared role handling withPolicyOnlyTrainer, allowing rollout-based algorithms to reuse the same infrastructure.DPO now inherits the generic role-aware mixin for its frozen reference model, while PPO inherits the role-aware policy trainer for its actor, reference, critic, and reward roles. Their existing training behavior is unchanged.
This refactor also provides a reusable foundation for future teacher-scored workflows such as OPD, where a trainable student performs rollouts and a frozen teacher scores the generated tokens.
Testing
Added CPU tests covering: