Skip to content

Fix adapter error handling and remove redundant null checks - #130

Merged
SamuelMcAravey merged 2 commits into
codex/2025-12-21-refactor-solution-for-transport-agnostic-modules-1ziys6from
copilot/sub-pr-129
Dec 21, 2025
Merged

Fix adapter error handling and remove redundant null checks#130
SamuelMcAravey merged 2 commits into
codex/2025-12-21-refactor-solution-for-transport-agnostic-modules-1ziys6from
copilot/sub-pr-129

Conversation

Copilot AI commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

Addressed review feedback on adapter error handling semantics and type safety violations.

Changes

  • WebhookEngineAdapter: Changed signature validation failure outcome from Retry to Acknowledge - authentication failures are not transient errors
  • WebhookEngineAdapter: Removed duplicate idempotency check block
  • UiEngineAdapter: Removed redundant null check after ResolveEngine call - method signature guarantees non-null via where TContract : notnull
  • ModuleEngineDiscoveryService: Fixed property access in error message - ModuleKey lives on descriptor, not manifest
// Before: infinite retry loop on auth failure
if (!signatureValidator.Validate(...))
    return new WebhookAdapterResponse(WebhookOutcomeType.Retry, "Signature validation failed");

// After: acknowledge and stop
if (!signatureValidator.Validate(...))
    return new WebhookAdapterResponse(WebhookOutcomeType.Acknowledge, "Signature validation failed");

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…nt checks

Co-authored-by: SamuelMcAravey <11021165+SamuelMcAravey@users.noreply.github.com>
Copilot AI changed the title [WIP] Strengthen engine descriptors and typed navigation Fix adapter error handling and remove redundant null checks Dec 21, 2025
Copilot AI requested a review from SamuelMcAravey December 21, 2025 05:30
@SamuelMcAravey
SamuelMcAravey marked this pull request as ready for review December 21, 2025 06:44
@SamuelMcAravey
SamuelMcAravey merged commit b754ca0 into codex/2025-12-21-refactor-solution-for-transport-agnostic-modules-1ziys6 Dec 21, 2025
@SamuelMcAravey
SamuelMcAravey deleted the copilot/sub-pr-129 branch December 21, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants