Fix adapter error handling and remove redundant null checks - #130
Merged
SamuelMcAravey merged 2 commits intoDec 21, 2025
Conversation
…nt checks Co-authored-by: SamuelMcAravey <11021165+SamuelMcAravey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Strengthen engine descriptors and typed navigation
Fix adapter error handling and remove redundant null checks
Dec 21, 2025
SamuelMcAravey
marked this pull request as ready for review
December 21, 2025 06:44
SamuelMcAravey
merged commit Dec 21, 2025
b754ca0
into
codex/2025-12-21-refactor-solution-for-transport-agnostic-modules-1ziys6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review feedback on adapter error handling semantics and type safety violations.
Changes
RetrytoAcknowledge- authentication failures are not transient errorsResolveEnginecall - method signature guarantees non-null viawhere TContract : notnullModuleKeylives on descriptor, not manifest💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.