Skip to content

Add RequiresDocker trait to database test collections - #135

Merged
SamuelMcAravey merged 3 commits into
mainfrom
copilot/fix-test-cases
Jan 28, 2026
Merged

Add RequiresDocker trait to database test collections#135
SamuelMcAravey merged 3 commits into
mainfrom
copilot/fix-test-cases

Conversation

Copilot AI commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

CI workflow filters tests using RequiresDocker!=true but SqlServerCollection and PostgresCollection lacked this trait, causing 20 Docker-dependent integration tests to fail in environments without Docker/sqlcmd.

Changes

  • Added [Trait("RequiresDocker", "true")] to SqlServerCollection and PostgresCollection class definitions
  • Implemented SqlServerCollectionFixture.EnsureAvailable() to throw descriptive error if fixture is accessed when Docker unavailable

Impact

  • 239 SQL Server integration tests now properly excluded from non-Docker CI runs
  • 229 unit tests continue to run in all environments
  • Postgres tests follow same pattern for consistency
Original prompt

Reference: https://github.com/bravellian/platform/actions/runs/21423632771/job/61687991204#step:10:1

Please fix these test and verify they work


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 28, 2026 04:38
Co-authored-by: SamuelMcAravey <11021165+SamuelMcAravey@users.noreply.github.com>
Co-authored-by: SamuelMcAravey <11021165+SamuelMcAravey@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing test cases and verify functionality Add RequiresDocker trait to database test collections Jan 28, 2026
Copilot AI requested a review from SamuelMcAravey January 28, 2026 04:49
@SamuelMcAravey
SamuelMcAravey marked this pull request as ready for review January 28, 2026 04:52
@SamuelMcAravey
SamuelMcAravey merged commit 51bc218 into main Jan 28, 2026
2 checks passed
@SamuelMcAravey
SamuelMcAravey deleted the copilot/fix-test-cases branch January 28, 2026 04:52
@github-actions

Copy link
Copy Markdown

Test Docs Summary

  • Total tests: 773
  • Compliant: 677 (87.6%)
  • Missing required: 96
  • Invalid format: 0

Artifacts: testdocs (docs/testing/generated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants